Skip to content

Nemobug2 - bug fixes for a certain set of NEMO output - #138

Open
bnlawrence wants to merge 8 commits into
NCAS-CMS:mainfrom
bnlawrence:nemobug2
Open

bnlawrence wants to merge 8 commits into
NCAS-CMS:mainfrom
bnlawrence:nemobug2

Conversation

@bnlawrence

Copy link
Copy Markdown

This PR addresses the issue outlined in #126, by making some fixes for curvilinear coordinate for normal plotting and with blockfill. This PR replaces #137 which was on top of a previous PR and unnecessarily complicated.

@sadielbartholomew

Copy link
Copy Markdown
Member

Have just resolved a trivial conflict (in the Changelog) to help me to review from a clean state. Now closing and re-opening the PR to trigger the new CI jobs which will help me to see the influence on the tests across Python versions and platforms.

@sadielbartholomew

Copy link
Copy Markdown
Member

Going to build on top of the initial PR @bnlawrence, since for setting up the reference conda environment and the CI jobs to run the tests with and without image comparison, I have created a new directory of reference images specific to those expected to the reference environment, namely tests/v350-controlled-env-ref-images.

So I will remove the updated tests/reference-example-images plots here and copy any changes due to the underlying bug fix across to tests/v350-controlled-env-ref-images. And generally work towards getting this ready to merge ASAP. I'll address any review comments directly as new commits in the view to get this merged quickly.

@sadielbartholomew

sadielbartholomew commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Mid-way through updating the PR to account for the new reference environment and matched reference plots directory. Note the 'files change' count looks quite bloated because I am updating the images the docs point to here also since I'm adding a new example for the NEMO grid as part of work related to NEMO and the bug manifesting with it before this fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants